TNTP-2109: call bucket_ref/bucket_unref on crud operations #463
+501
−174
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Satbek
changed the title
Satbek
force-pushed
the
TNTP-2109-bucket-ref-unref
branch
9 times, most recently
from
45dc21b to
e19fc3e
Compare
ita-sammann
reviewed
Nov 26, 2025
ita-sammann
reviewed
Nov 28, 2025
ita-sammann
reviewed
Nov 28, 2025
ita-sammann
approved these changes
Dec 2, 2025
Satbek
force-pushed
the
TNTP-2109-bucket-ref-unref
branch
4 times, most recently
from
123d504 to
83c2fdc
Compare
In fast mode ref/unref do nothing. In safe mode they call bucket_refro,bucket_refrw, bucket_unrefo,bucket_unrefrw. Also added ref error handle from storages. On ref error router will reset bucket, change replicaset for single operations and retry request.
* add access to _bucket space in privillage tests * fix select_readview_test * enable double buckets test * add safe_mode_disable for cartirdge reload test: test_storage * add safe_mode_disable for test_any_vshard_call_timeout
Satbek
force-pushed
the
TNTP-2109-bucket-ref-unref
branch
from
83c2fdc to
d41e509
Compare
|
Commits cherry-picked to #467 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added module bucket_ref_unref.lua with functions bucket_refrw, bucket_unrefrw, bucket_refro, etc ...
module looks at rebalancer.safe_mode flag. if it's disabled module does nothing, otherwise module call ref fucnctions
bucket_ref fail indicated bucket movement.
it will help with problem with double buckets.
What has been done? Why? What problem is being solved?
I didn't forget about
Closes #???